Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r70449078 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala --- @@ -34,7 +34,7 @@ import org.apache.spark.sql.types.DataType abstract class AbstractSqlParser extends ParserInterface with Logging { /** Creates/Resolves DataType for a given SQL string. */ - def parseDataType(sqlText: String): DataType = parse(sqlText) { parser => + override def parseDataType(sqlText: String): DataType = parse(sqlText) { parser => // TODO add this to the parser interface. --- End diff -- Remove TODO :)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org