Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r70459222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -237,6 +229,9 @@ case class Divide(left: Expression, right: Expression)
}
}
+ // Used by doGenCode
+ protected def divide(eval1: ExprCode, eval2: ExprCode, javaType:
String): String
--- End diff --
you can see from [this
test](https://github.com/apache/spark/pull/14036/files#diff-f3fc3b985a8877ee493f1a12ddfb98d6L143)
that the previous `Divide` expression can support all integral types and
fraction types.
BTW looks there is no special handling for integral type in your PR, for
fraction type:
```
if (dataType.isInstanceOf[DecimalType]) {
s"${eval1.value}.$decimalMethod(${eval2.value})"
} else {
s"($javaType)(${eval1.value} $symbol ${eval2.value})"
}
```
while the `symbol` is `/`, so we generate `($javaType)(${eval1.value} /
${eval2.value})` for double and float.
for integral type:
```
($javaType)(${eval1.value} $decimalMethod (${eval2.value}))
```
while the `decimalMethod` is `/`, so it's still generates
`($javaType)(${eval1.value} / ${eval2.value})`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
