Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r70562757
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -249,11 +241,12 @@ case class Divide(left: Expression, right: Expression)
s"${eval2.value} == 0"
}
val javaType = ctx.javaType(dataType)
- val divide = if (dataType.isInstanceOf[DecimalType]) {
+ val divide = if (dataType.isInstanceOf[DecimalType] ||
dataType.isInstanceOf[DoubleType]) {
s"${eval1.value}.$decimalMethod(${eval2.value})"
} else {
- s"($javaType)(${eval1.value} $symbol ${eval2.value})"
+ s"($javaType)(${eval1.value} $decimalMethod ${eval2.value})"
--- End diff --
ok I see the problem. Since `symbol` is also used in the string format of
arithmetic expression, `IntegerDivide` has to override it.
I think we can:
1. inline the operator in generated code, e.g. `($javaType)(${eval1.value}
/ ${eval2.value})` instead of `($javaType)(${eval1.value} $symbol
${eval2.value})`
2. don't override `decimalMethod` as it's useless in the 2 division
expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
