Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14148#discussion_r70571914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -413,38 +413,36 @@ case class DescribeTableCommand(table:
TableIdentifier, isExtended: Boolean, isF
} else {
val metadata = catalog.getTableMetadata(table)
+ if (DDLUtils.isDatasourceTable(metadata)) {
+ DDLUtils.getSchemaFromTableProperties(metadata) match {
+ case Some(userSpecifiedSchema) =>
describeSchema(userSpecifiedSchema, result)
+ case None =>
describeSchema(catalog.lookupRelation(table).schema, result)
+ }
+ } else {
+ describeSchema(metadata.schema, result)
+ }
--- End diff --
How about we try to put these into describeSchema? Of, maybe we can add a
`describeSchema(tableName, result)`? Seems it is weird that `describeExtended`
and `describeFormatted` do not contain the code for describing the schema.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
