Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14148#discussion_r70578153
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -413,38 +413,36 @@ case class DescribeTableCommand(table:
TableIdentifier, isExtended: Boolean, isF
} else {
val metadata = catalog.getTableMetadata(table)
+ if (DDLUtils.isDatasourceTable(metadata)) {
+ DDLUtils.getSchemaFromTableProperties(metadata) match {
+ case Some(userSpecifiedSchema) =>
describeSchema(userSpecifiedSchema, result)
+ case None =>
describeSchema(catalog.lookupRelation(table).schema, result)
+ }
+ } else {
+ describeSchema(metadata.schema, result)
+ }
--- End diff --
@yhuai I just did a try. We have to pass `CatalogTable` for avoiding
another call of `getTableMetadata`. We also need to pass `SessionCatalog` for
calling `lookupRelation`. Do you like this function? or keep the existing one?
Thanks!
```Scala
private def describeSchema(
tableDesc: CatalogTable,
catalog: SessionCatalog,
buffer: ArrayBuffer[Row]): Unit = {
if (DDLUtils.isDatasourceTable(tableDesc)) {
DDLUtils.getSchemaFromTableProperties(tableDesc) match {
case Some(userSpecifiedSchema) =>
describeSchema(userSpecifiedSchema, buffer)
case None => describeSchema(catalog.lookupRelation(table).schema,
buffer)
}
} else {
describeSchema(tableDesc.schema, buffer)
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
