Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14137#discussion_r70664836
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/lib/StronglyConnectedComponents.scala
---
@@ -106,6 +116,16 @@ object StronglyConnectedComponents {
}
},
(final1, final2) => final1 || final2)
+
+ // ensure sccGraph's rdd are marked as recently used
+ sccGraph.vertices.count()
+ sccGraph.edges.count()
+ // sccGraph materialized so, unpersist can be done on previous
+ if(prevSccGraph != sccGraph)
--- End diff --
I think this will fail style checks but let's see.
Hm, I think it's straightforward to follow the same pattern for the other
RDD, but yes it's updated in enough places that it's a fair bit of extra code.
It might be possible to refactor this nicely in some method.
Not essential, maybe. This code isn't used much anyway. A partial
improvement may be a sufficient win.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
