Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14137#discussion_r70672178
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/lib/StronglyConnectedComponents.scala
---
@@ -106,6 +116,11 @@ object StronglyConnectedComponents {
}
},
(final1, final2) => final1 || final2)
+
+ // ensure sccGraph's rdd are marked as recently used to not be
evicted between iterations
--- End diff --
OK, the rest of the changes much looks like an improvement, at the least. I
am not as sure why this is necessary. It's already materialized at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
