Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14201#discussion_r70870990
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -455,6 +542,36 @@ private ProcessBuilder createBuilder() {
for (Map.Entry<String, String> e : builder.childEnv.entrySet()) {
pb.environment().put(e.getKey(), e.getValue());
}
+
+ if (builder.workingDir != null) {
+ pb.directory(builder.workingDir);
+ }
+
+ // Only one of redirectError, redirectError(...) can be specified.
+ // If redirectToLog() is specified, none of the other redirect options
can be specified
+ if (builder.redirectToLog &&
+ (builder.redirectErrorStream
+ || (builder.errorStream != null)
+ || (builder.outputStream != null))) {
+ throw new IllegalStateException("Cannot specify redirectToLog() in
conjunction with other " +
+ "redirection operations.");
+ }
+
+ // Only one of redirectError and redirectError(...) can be specified
+ if (builder.redirectErrorStream && builder.errorStream != null) {
--- End diff --
Probably ok to leave this one, but `ProcessBuilder` allows it even if it
doesn't do what you'd expect.
```
new ProcessBuilder(java.util.Arrays.asList("ls",
"/foo")).redirectErrorStream(true).redirectError(ProcessBuilder.Redirect.INHERIT).start()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
