Github user andreweduffy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14201#discussion_r70904921
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -82,8 +83,12 @@
       /** Used internally to create unique logger names. */
       private static final AtomicInteger COUNTER = new AtomicInteger();
     
    +  public static final ThreadFactory REDIRECTOR_FACTORY = new 
NamedThreadFactory("launcher-proc-%d");
    --- End diff --
    
    How should this be shared do you think without making it public static in 
either SparkLauncher or ChildProcApphandle?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to