Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14065#discussion_r71107536
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala
 ---
    @@ -69,6 +71,9 @@ private[yarn] class AMDelegationTokenRenewer(
       private val freshHadoopConf =
         hadoopUtil.getConfBypassingFSCache(hadoopConf, new 
Path(credentialsFile).toUri.getScheme)
     
    +  @volatile private var timeOfNextRenewal =
    +    sparkConf.get(CREDENTIALS_RENEWAL_TIME).getOrElse(Long.MaxValue)
    --- End diff --
    
    One possible scenario from current code is that if principal and keytab is 
configured, but all credential are non-renewable or disabled. In such case 
`CREDENTIALS_RENEWAL_TIME` may be empty but `AMDelegationTokenRenewer` will 
still be started because it only relies on principal configured or not. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to