Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r71111198
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala
---
@@ -193,8 +200,14 @@ private[yarn] class AMDelegationTokenRenewer(
}
}
val nextSuffix = lastCredentialsFileSuffix + 1
+ // Time of next update should be late than renewal,
+ // which is around new token issue date + 0.8 * renew interval
+ val timeOfNextUpdate =
--- End diff --
Not sure how this part could be consolidate into `obtainCredentials`
method, the return value of `obtainCredentials` is time of next renewal, here
it is time of next updating, which should be slightly later than next renewal.
So in shortly IIUC if we also want to consolidate this code, so we should
change the return value `obtainCredentials` to `(timeOfNextRenewal,
timeOfNextUpdate)`, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
