Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r71683008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -356,8 +372,14 @@ class SQLBuilder(logicalPlan: LogicalPlan) extends Logging { } } + val broadcastHint = project match { + case p @ Project(projectList, Hint("BROADCAST", tables, child)) => + if (tables.nonEmpty) s"/*+ MAPJOIN(${tables.mkString(", ")}) */" else "" + case _ => "" + } build( "SELECT", + broadcastHint, --- End diff -- Hmm. For this one, I found more reasonable solution. Instead of adding new dummy `Project`, we can utilize the existing dummy `Project` on the `SQLTable`. Basically, the root cause of this problem of `groupingSetToSQL` is that it removes the project by doing this `toSQL(project.child)`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org