Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71736274
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -162,6 +162,9 @@ class SQLBuilder(logicalPlan: LogicalPlan) extends
Logging {
toSQL(p.right),
p.condition.map(" ON " + _.sql).getOrElse(""))
+ case h @ Hint(_, _, s @ SubqueryAlias(alias, p @ Project(_, _:
SQLTable))) =>
--- End diff --
The new way looks cleaner, but this looks like a special handling. Can you
write a code comment to explain when it is being used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
