Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14373#discussion_r72352218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -608,7 +608,8 @@ private[execution] final class LongToUnsafeRowMap(val
mm: TaskMemoryManager, cap
def optimize(): Unit = {
val range = maxKey - minKey
// Convert to dense mode if it does not require more memory or could
fit within L1 cache
- if (range < array.length || range < 1024) {
+ // SPARK-16740: Make sure range doesn't overflow if minKey has a large
negative value
+ if (range >= 0 && (range < array.length || range < 1024)) {
--- End diff --
I'm not a Spark committer, but it looks good to me.
By the way, what about removing the `SPARK-16740` comment? I think the code
is intuitive enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
