Github user sylvinus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14373#discussion_r72464273
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -608,7 +608,8 @@ private[execution] final class LongToUnsafeRowMap(val
mm: TaskMemoryManager, cap
def optimize(): Unit = {
val range = maxKey - minKey
--- End diff --
Not a Scala expert so I'll trust your judgement!
`maxKey` being initialized to `Long.MinValue`, I wasn't sure of all the
cases where `range` could end up negative so `range >=0` seemed the safest
thing to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
