Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r72485685
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -97,6 +97,49 @@ package object config {
         .toSequence
         .createWithDefault(Nil)
     
    +  // Blacklist confs
    +  private[spark] val BLACKLIST_ENABLED =
    +    ConfigBuilder("spark.blacklist.enabled")
    +    .booleanConf
    +    .createOptional
    +
    +  private[spark] val MAX_TASK_ATTEMPTS_PER_NODE =
    +    ConfigBuilder("spark.blacklist.maxTaskAttemptsPerNode")
    +    .intConf
    +    .createWithDefault(2)
    +
    +  private[spark] val MAX_FAILURES_PER_EXEC =
    +    ConfigBuilder("spark.blacklist.maxFailedTasksPerExecutor")
    +    .intConf
    +    .createWithDefault(2)
    +
    +  private[spark] val MAX_FAILURES_PER_EXEC_STAGE =
    +    ConfigBuilder("spark.blacklist.maxFailedTasksPerExecutorStage")
    --- End diff --
    
    As discussed in the design doc, I think this would be slightly more clear 
(and the hierarchy of configurations would be more clear) if this were 
spark.blacklist.stage.maxFailedTasksPerExecutor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to