Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r72486743
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -97,6 +97,49 @@ package object config {
.toSequence
.createWithDefault(Nil)
+ // Blacklist confs
+ private[spark] val BLACKLIST_ENABLED =
+ ConfigBuilder("spark.blacklist.enabled")
+ .booleanConf
+ .createOptional
+
+ private[spark] val MAX_TASK_ATTEMPTS_PER_NODE =
+ ConfigBuilder("spark.blacklist.maxTaskAttemptsPerNode")
+ .intConf
+ .createWithDefault(2)
+
+ private[spark] val MAX_FAILURES_PER_EXEC =
+ ConfigBuilder("spark.blacklist.maxFailedTasksPerExecutor")
+ .intConf
+ .createWithDefault(2)
+
+ private[spark] val MAX_FAILURES_PER_EXEC_STAGE =
+ ConfigBuilder("spark.blacklist.maxFailedTasksPerExecutorStage")
+ .intConf
+ .createWithDefault(2)
+
+ private[spark] val MAX_FAILED_EXEC_PER_NODE =
+ ConfigBuilder("spark.blacklist.maxFailedExecutorsPerNode")
+ .intConf
+ .createWithDefault(2)
+
+ private[spark] val MAX_FAILED_EXEC_PER_NODE_STAGE =
+ ConfigBuilder("spark.blacklist.maxFailedExecutorsPerNodeStage")
+ .intConf
+ .createWithDefault(2)
+
+ private[spark] val BLACKLIST_EXPIRY_TIMEOUT_CONF =
+ ConfigBuilder("spark.scheduler.blacklist.recoverPeriod")
--- End diff --
Do you think timeout is more clear here?
(spark.scheduler.blacklist.timeout) or expiryTimeout or expireTimeout?
"recover" can have various meanings -- and we're not actively recovering the
machine, or doing any test of whether it's recovered, so I think the simpler
semantics of timeout or expiryTimeout might be more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
