Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72769633 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuite with ExpressionEvalHelper { } } + test("cast struct with a timestamp field") { + val origSchema = StructType( + Seq(StructField( "tsField", TimestampType, false )) + ) + val trgSchema = StructType( + // nine out of ten times I'm casting a struct, it's to normalize its fields nullability + Seq(StructField( "tsField", TimestampType, true )) + ) + val inp = Literal.create(InternalRow(0L), origSchema) --- End diff -- This is an internal row,timestamps are represented as longs. We can probably use a more meaningful date literal
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org