Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14400#discussion_r72897142
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
 ---
    @@ -727,6 +727,16 @@ class CastSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         }
       }
     
    +  test("cast struct with a timestamp field") {
    +    val originalSchema = new StructType().add("tsField", TimestampType, 
nullable = false)
    +    // nine out of ten times I'm casting a struct, it's to normalize its 
fields nullability
    +    val targetSchema = new StructType().add("tsField", TimestampType, 
nullable = true)
    +
    +    val inp = Literal.create(InternalRow(0L), originalSchema)
    +    val expected = InternalRow(0L)
    +    checkEvaluation(cast(inp, targetSchema), expected )
    --- End diff --
    
    and remove the extra space here too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to