Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14176#discussion_r73038709 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -660,36 +778,74 @@ case class HashAggregateExec( } } + val updateRowInVectorizedHashMap: Option[String] = { --- End diff -- This and `updateRowInRowBasedHashMap` seem to have a lot of duplicated code. Can this be avoided?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org