Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73070005
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,15 @@ case class HashAggregateExec(
.map(_.asInstanceOf[DeclarativeAggregate])
private val bufferSchema =
StructType.fromAttributes(aggregateBufferAttributes)
- // The name for Vectorized HashMap
- private var vectorizedHashMapTerm: String = _
- private var isVectorizedHashMapEnabled: Boolean = _
+ // The name for Fast HashMap
+ private var fastHashMapTerm: String = _
+ // whether vectorized hashmap or row based hashmap is enabled
+ // we make sure that at most one of the two flags is true
+ // i.e., assertFalse(isVectorizedHashMapEnabled &&
isRowBasedHashMapEnabled)
+ private var isVectorizedHashMapEnabled: Boolean = false
+ private var isRowBasedHashMapEnabled: Boolean = false
+ // auxiliary flag, true if any of two above is true
+ private var isFastHashMapEnabled: Boolean = false
--- End diff --
Sure, what I meant was that we can even initialize it with
`isVectorizedHashMapEnabled || isRowBasedHashMapEnabled` to make the implied
semantics clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
