Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73464594
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -154,6 +274,21 @@ private[sql] case class PreWriteCheck(conf: SQLConf,
catalog: SessionCatalog)
def apply(plan: LogicalPlan): Unit = {
plan.foreach {
+ case c @ CreateTable(tableDesc, mode, query) if c.resolved =>
+ // Since we are saving table metadata to metastore, we should make
sure the table name
+ // and database name don't break some common restrictions, e.g.
special chars except
+ // underscore are not allowed.
+ val pattern = Pattern.compile("[\\w_]+")
--- End diff --
cc @hvanhovell , I think this is the only place that we need this check, as
`CreateTable` is the only plan that can save a table metadata into metastore.
what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
