Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14482#discussion_r73467397
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala 
---
    @@ -206,22 +206,22 @@ private[sql] case class PreWriteCheck(conf: SQLConf, 
catalog: SessionCatalog)
             // The relation in l is not an InsertableRelation.
             failAnalysis(s"$l does not allow insertion.")
     
    -      case c: CreateTableUsingAsSelect =>
    +      case CreateTable(tableDesc, mode, Some(query)) =>
    --- End diff --
    
    The exception is CREATE HIVE TABLE AS SELECT. So far, we assume all the 
unsupported cases have been captured in the DDL handling. Thus, I think it is 
safe to apply all the cases to Hive Tables. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to