Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13950#discussion_r73758012
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -186,6 +188,66 @@ private[spark] object JettyUtils extends Logging {
         contextHandler
       }
     
    +  /** Create a handler for proxying request to Workers and Application 
Drivers */
    +  def createProxyHandler(
    +      prefix: String,
    +      target: String): ServletContextHandler = {
    +    val servlet = new ProxyServlet {
    +      override def rewriteTarget(request: HttpServletRequest): String = {
    +        val path = request.getRequestURI();
    +        if (!path.startsWith(prefix)) return null
    +
    +        val uri = new StringBuilder(target)
    +        if (target.endsWith("/")) uri.setLength(uri.length() - 1)
    +        val rest = path.substring(prefix.length())
    +        if (!rest.isEmpty()) {
    +          if (!rest.startsWith("/")) {
    +            uri.append("/")
    +          }
    +          uri.append(rest)
    +        }
    +
    +        val query = request.getQueryString()
    +        if (query != null) {
    +          // Is there at least one path segment ?
    +          val separator = "://"
    +          if (uri.indexOf("/", uri.indexOf(separator) + 
separator.length()) < 0) {
    +            uri.append("/")
    +          }
    +          uri.append("?").append(query)
    +        }
    +        val rewrittenURI = URI.create(uri.toString()).normalize()
    +
    +        if (!validateDestination(rewrittenURI.getHost(), 
rewrittenURI.getPort())) {
    +          return null
    +        }
    +
    +        rewrittenURI.toString();
    +      }
    +      override def filterServerResponseHeader(
    +        clientRequest: HttpServletRequest,
    --- End diff --
    
    style: multi-line argument lists need to be indented one extra level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to