Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13950#discussion_r73759305 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -186,6 +188,67 @@ private[spark] object JettyUtils extends Logging { contextHandler } + /** Create a handler for proxying request to Workers and Application Drivers */ + def createProxyHandler( --- End diff -- +1 to targeted tests of string manipulation code. Move the string manipulation part into its own method, and write targeted unit tests for it.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org