Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2002#discussion_r16331781 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -451,10 +451,56 @@ private[spark] object Utils extends Logging { /** * Get a temporary directory using Spark's spark.local.dir property, if set. This will always * return a single directory, even though the spark.local.dir property might be a list of - * multiple paths. + * multiple paths. If the SPARK_LOCAL_DIRS environment variable is set, then this will return + * a directory from that variable. */ def getLocalDir(conf: SparkConf): String = { - conf.get("spark.local.dir", System.getProperty("java.io.tmpdir")).split(',')(0) + getOrCreateLocalRootDirs(conf)(0) + } + + /** + * Gets or creates the directories listed in spark.local.dir or SPARK_LOCAL_DIRS, + * and returns only the directories that exist / could be created. + */ + private[spark] def getOrCreateLocalRootDirs(conf: SparkConf): Array[String] = { + val isYarn = java.lang.Boolean.valueOf( + System.getProperty("SPARK_YARN_MODE", conf.getenv("SPARK_YARN_MODE"))) --- End diff -- @tgravescs, it would be great if you could take a look at the YARN logic below to see whether I've gotten it right. Most of the code is a straight copy-paste from the old code in Executor, but I want to make sure that I'm not overlooking any corner-cases related to SPARK_YARN_MODE being set on the driver.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org