Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2002#discussion_r16365281
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -451,10 +451,56 @@ private[spark] object Utils extends Logging {
/**
* Get a temporary directory using Spark's spark.local.dir property, if
set. This will always
* return a single directory, even though the spark.local.dir property
might be a list of
- * multiple paths.
+ * multiple paths. If the SPARK_LOCAL_DIRS environment variable is set,
then this will return
+ * a directory from that variable.
*/
def getLocalDir(conf: SparkConf): String = {
- conf.get("spark.local.dir",
System.getProperty("java.io.tmpdir")).split(',')(0)
+ getOrCreateLocalRootDirs(conf)(0)
+ }
+
+ /**
+ * Gets or creates the directories listed in spark.local.dir or
SPARK_LOCAL_DIRS,
+ * and returns only the directories that exist / could be created.
+ */
+ private[spark] def getOrCreateLocalRootDirs(conf: SparkConf):
Array[String] = {
+ val isYarn = java.lang.Boolean.valueOf(
+ System.getProperty("SPARK_YARN_MODE",
conf.getenv("SPARK_YARN_MODE")))
--- End diff --
If this becomes really expensive (e.g. many calls to fetchFile), you could
cache the result in a field of SparkConf (or just make this into a private
instance method of SparkConf). I could make those changes now, or we could
wait to see if this is an actual performance problem.
I guess the correct YARN logic is "if this process is running inside of a
YARN container, then use the YARN directories". If so, I need a way to
determine `isRunningInYarnContainer.` Is `SPARK_YARN_MODE` the right way to do
this, or should I be using some other signal (or does SPARK_YARN_MODE need to
be set differently so that it's not set on the driver when running in client
mode)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
