Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13146#discussion_r73978068
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -64,6 +64,10 @@
       /** Configuration key for the number of executor CPU cores. */
       public static final String EXECUTOR_CORES = "spark.executor.cores";
     
    +  public static final String PYSPARK_DRIVER_PYTHON = 
"spark.pyspark.driver.python";
    --- End diff --
    
    Do you mean to define them in 2 places (`package.scala` & `SparkLauncher`) 
? This may cause some inconsistency in future although it is very unlikely to 
change them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to