Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13146#discussion_r74101878
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -89,6 +89,11 @@ public void testSparkArgumentHandling() throws Exception
{
launcher.setConf("spark.foo", "foo");
launcher.addSparkArg(opts.CONF, "spark.foo=bar");
assertEquals("bar", launcher.builder.conf.get("spark.foo"));
+
+ launcher.setConf(SparkLauncher.PYSPARK_DRIVER_PYTHON, "python3.4");
+ launcher.setConf(SparkLauncher.PYSPARK_PYTHON, "python3.5");
+ assertEquals("python3.4",
launcher.builder.conf.get("spark.pyspark.driver.python"));
--- End diff --
It would be better if you checked `PYSPARK_DRIVER_PYTHON.key()`, but I
don't know how easy it is to call that from Java. (You could create a tiny
scala test class for that in `core/src/test/scala/org/apache/spark/launcher`.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
