Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14558#discussion_r74012847
--- Diff: R/pkg/R/generics.R ---
@@ -395,6 +396,9 @@ setGeneric("value", function(bcast) {
standardGeneric("value") })
#################### SparkDataFrame Methods ########################
+#' @param x a SparkDataFrame or GroupedData.
--- End diff --
Hmm.. I see why this would be a place for it. I think it would be easier to
maintain if the documentation is next to the function body instead of the
generics, but I haven't completely figure the best way to do yet.
The approach we have so far is to keep most of the tag/doc on one of the
definition - do you think it would work here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
