Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1723#discussion_r16337606
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -813,7 +816,10 @@ private[spark] object Utils extends Logging {
        * A regular expression to match classes of the "core" Spark API that we 
want to skip when
        * finding the call site of a method.
        */
    -  private val SPARK_CLASS_REGEX = 
"""^org\.apache\.spark(\.api\.java)?(\.util)?(\.rdd)?\.[A-Z]""".r
    +  private val SPARK_CLASS_REGEX = 
"""^org\.apache\.spark(\.api\.java)?(\.util)?(\.rdd)?(\.streaming)?(\.streaming\.dstream)?(\.streaming\.scheduler)?(\.streaming\.twitter)?(\.streaming\.kafka)?(\.streaming\.flume)?(\.streaming\.mqtt)?(\.streaming\.zeromq)?\.[A-Z]""".r
    +  private val SCALA_CLASS_REGEX = 
"""^scala(\.util)?(\.collection)?(\.collection\.mutable)?(\.collection\.immutable)?(\.concurrent\.forkjoin)?\.[A-Z]""".r
    --- End diff --
    
    Aah, I guessed so. But this does change how callsites will get interpreted 
for general Spark programs as well. Will need some more input from others 
regarding this. @andrewor14 Can you take a look at this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to