Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1723#discussion_r16337761
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -813,7 +816,10 @@ private[spark] object Utils extends Logging {
* A regular expression to match classes of the "core" Spark API that we
want to skip when
* finding the call site of a method.
*/
- private val SPARK_CLASS_REGEX =
"""^org\.apache\.spark(\.api\.java)?(\.util)?(\.rdd)?\.[A-Z]""".r
+ private val SPARK_CLASS_REGEX =
"""^org\.apache\.spark(\.api\.java)?(\.util)?(\.rdd)?(\.streaming)?(\.streaming\.dstream)?(\.streaming\.scheduler)?(\.streaming\.twitter)?(\.streaming\.kafka)?(\.streaming\.flume)?(\.streaming\.mqtt)?(\.streaming\.zeromq)?\.[A-Z]""".r
+ private val SCALA_CLASS_REGEX =
"""^scala(\.util)?(\.collection)?(\.collection\.mutable)?(\.collection\.immutable)?(\.concurrent\.forkjoin)?\.[A-Z]""".r
--- End diff --
Actually, second thought. I am wondering that should all the spark classes
be ignored directly? That is all classes `org.apache.spark.*`? Why include
subpackages in the regular expressions? Are there some internal Spark classes
that we want to show up in the callsite shortform?
@andrewor14 What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
