Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9571#discussion_r74911975
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -114,28 +123,45 @@ class HistoryServer(
* this UI with the event logs in the provided base directory.
*/
def initialize() {
- attachPage(new HistoryPage(this))
+ if (!initialized.getAndSet(true)) {
--- End diff --
...Pulled it from the test suite, so the check is superflous, and cut it...
Looking at this more, I think the metrics setup should be moved to
`bind()`, rather than `initialize()`, precisely because the metrics setup may
be doing things in terms of thread startup, and you don't want that to happen
so early in class construction. Doing that and the testing/review to make sure
that the later-metrics-init won't break assumptions elsewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
