Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9571#discussion_r74960995
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -226,6 +259,135 @@ class HistoryServer(
}
/**
+ * An abstract implementation of the metrics [[Source]] trait with some
common operations.
+ */
+private[history] abstract class HistoryMetricSource(val prefix: String)
extends Source {
--- End diff --
done; also made the`Timestamp` gauge take a Spark `Clock` for easier
use/testing, plus some other standalone tests. Separate source file -> isolated
tests.
These gauges are actually generic to any metrics, and the `LambdaLongGauge`
gauge quite a nice one to use in a lot of places; if accompanied with
`LambdaIntGauge` they could be used as a more functional equivalent to the
various gauge subclasses throughout the code. I could put them somewhere more
generic if you think its useful (and even, in a different patch, move the
existing gauges over to them)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
