Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r75066185
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -81,6 +86,18 @@ private[spark] class HiveExternalCatalog(client:
HiveClient, hadoopConf: Configu
withClient { getTable(db, table) }
}
+ /**
+ * If the given table properties contains datasource properties, throw
an exception.
+ */
+ private def verifyTableProperties(table: CatalogTable): Unit = {
+ val datasourceKeys =
table.properties.keys.filter(_.startsWith(DATASOURCE_PREFIX))
+ if (datasourceKeys.nonEmpty) {
+ throw new AnalysisException(s"Cannot persistent
${table.qualifiedName} into hive metastore " +
+ s"as table property keys may not start with '$DATASOURCE_PREFIX':
" +
+ datasourceKeys.mkString("[", ", ", "]"))
+ }
+ }
--- End diff --
yea, e.g. `CreateTableLike`. But `restoreTableMetadata` generates table
without the data source table properties, and should be ok here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
