Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r75250996
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -97,16 +92,17 @@ case class CreateDataSourceTableCommand(
}
}
- CreateDataSourceTableUtils.createDataSourceTable(
- sparkSession = sparkSession,
- tableIdent = tableIdent,
+ val table = CatalogTable(
+ identifier = tableIdent,
+ tableType = if (isExternal) CatalogTableType.EXTERNAL else
CatalogTableType.MANAGED,
+ storage = CatalogStorageFormat.empty.copy(properties =
optionsWithPath),
schema = dataSource.schema,
- partitionColumns = partitionColumns,
- bucketSpec = bucketSpec,
- provider = provider,
- options = optionsWithPath,
--- End diff --
I put the options in `CatalogStorageFormat.properties`, and when the table
is read back, we will get the storage.properties as the data source options for
create relation, see
https://github.com/apache/spark/pull/14155/files#diff-d99813bd5bbc18277e4090475e4944cfR214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
