Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2002#discussion_r16398417
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -62,7 +62,7 @@ private[spark] class PythonRDD(
val env = SparkEnv.get
val localdir = env.blockManager.diskBlockManager.localDirs.map(
f => f.getPath()).mkString(",")
- envVars += ("SPARK_LOCAL_DIR" -> localdir) // it's also used in
monitor thread
+ envVars += ("SPARK_LOCAL_DIRS" -> localdir) // it's also used in
monitor thread
--- End diff --
I think so. It looks like it was innocuous because both the Java and
Python sides had the _same_ typo.
I suppose it might be cleaner here to read the local directories using the
methods in Utils instead of reading them out of diskBlockManager, but I think
this code is correct as written.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
