Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2002#discussion_r16398888
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -131,10 +132,9 @@ private[spark] class
DiskBlockManager(shuffleBlockManager: ShuffleBlockManager,
(blockId, getFile(blockId))
}
- private def createLocalDirs(): Array[File] = {
- logDebug(s"Creating local directories at root dirs '$rootDirs'")
+ private def createLocalDirs(conf: SparkConf): Array[File] = {
val dateFormat = new SimpleDateFormat("yyyyMMddHHmmss")
- rootDirs.split(",").flatMap { rootDir =>
+ Utils.getOrCreateLocalRootDirs(conf).flatMap { rootDir =>
--- End diff --
Actually, I think this code works correctly as written. If
`getOrCreateLocalRootDirs()` returns an empty list, then `createLocalDirs()`
will return an empty list, but its caller immediately checks whether the result
is empty; if it is, it logs an error and exits the JVM. This is the same
behavior as before (since the code below never actually throws any uncaught
exceptions).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
