Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14705#discussion_r75424161
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2702,19 +2710,21 @@ setMethod("from_unixtime", signature(x = "Column"),
     #' [12:05,12:10) but not in [12:00,12:05). Windows can support microsecond 
precision. Windows in
     #' the order of months are not supported.
     #'
    -#' The time column must be of TimestampType.
    -#'
    -#' Durations are provided as strings, e.g. '1 second', '1 day 12 hours', 
'2 minutes'. Valid
    -#' interval strings are 'week', 'day', 'hour', 'minute', 'second', 
'millisecond', 'microsecond'.
    -#' If the `slideDuration` is not provided, the windows will be tumbling 
windows.
    -#'
    -#' The startTime is the offset with respect to 1970-01-01 00:00:00 UTC 
with which to start
    -#' window intervals. For example, in order to have hourly tumbling windows 
that start 15 minutes
    -#' past the hour, e.g. 12:15-13:15, 13:15-14:15... provide `startTime` as 
`15 minutes`.
    -#'
    -#' The output column will be a struct called 'window' by default with the 
nested columns 'start'
    -#' and 'end'.
    -#'
    +#' @param x a time Column. Must be of TimestampType.
    +#' @param windowDuration a string specifying the width of the window, e.g. 
'1 second',
    +#'                       '1 day 12 hours', '2 minutes'. Valid interval 
strings are 'week',
    +#'                       'day', 'hour', 'minute', 'second', 'millisecond', 
'microsecond'.
    +#' @param slideDuration a string specifying the sliding interval of the 
window. Same format as
    +#'                      \code{windowDuration}. A new window will be 
generated every
    +#'                      \code{slideDuration}. Must be less than or equal to
    +#'                      the \code{windowDuration}.
    +#' @param startTime the offset with respect to 1970-01-01 00:00:00 UTC 
with which to start
    +#'                  window intervals. For example, in order to have hourly 
tumbling windows
    +#'                  that start 15 minutes past the hour, e.g. 12:15-13:15, 
13:15-14:15... provide
    +#'                  \code{startTime} as \code{"15 minutes"}.
    +#' @param ... further arguments to be passed to or from other methods.
    --- End diff --
    
    should this be
    `@param ... currently not used.`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to