Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14705#discussion_r75424346
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -999,9 +1008,10 @@ setMethod("dim",
     
     #' Collects all the elements of a SparkDataFrame and coerces them into an 
R data.frame.
     #'
    -#' @param x A SparkDataFrame
    -#' @param stringsAsFactors (Optional) A logical indicating whether or not 
string columns
    +#' @param x a SparkDataFrame.
    +#' @param stringsAsFactors (Optional) a logical indicating whether or not 
string columns
     #' should be converted to factors. FALSE by default.
    +#' @param ... further arguments to be passed to or from other methods.
    --- End diff --
    
    should this be
    `@param ... currently not used.`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to