Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r75432051
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -985,35 +987,37 @@ class MetastoreDataSourcesSuite extends QueryTest
with SQLTestUtils with TestHiv
withTempDir { tempPath =>
val schema = StructType((1 to 5).map(i => StructField(s"c_$i",
StringType)))
- createDataSourceTable(
- sparkSession = spark,
- tableIdent = TableIdentifier("not_skip_hive_metadata"),
+ val tableDesc1 = CatalogTable(
+ identifier = TableIdentifier("not_skip_hive_metadata"),
+ tableType = CatalogTableType.EXTERNAL,
+ storage = CatalogStorageFormat.empty.copy(
+ properties = Map("path" -> tempPath.getCanonicalPath,
"skipHiveMetadata" -> "false")
+ ),
schema = schema,
- partitionColumns = Array.empty[String],
- bucketSpec = None,
- provider = "parquet",
- options = Map("path" -> tempPath.getCanonicalPath,
"skipHiveMetadata" -> "false"),
- isExternal = false)
+ provider = Some("parquet")
+ )
+ spark.sessionState.catalog.createTable(tableDesc1, ignoreIfExists =
false)
// As a proxy for verifying that the table was stored in Hive
compatible format,
// we verify that each column of the table is of native type
StringType.
- assert(sharedState.externalCatalog.getTable("default",
"not_skip_hive_metadata").schema
+ assert(hiveClient.getTable("default",
"not_skip_hive_metadata").schema
.forall(_.dataType == StringType))
- createDataSourceTable(
- sparkSession = spark,
- tableIdent = TableIdentifier("skip_hive_metadata"),
+ val tableDesc2 = CatalogTable(
+ identifier = TableIdentifier("skip_hive_metadata",
Some("default")),
+ tableType = CatalogTableType.EXTERNAL,
+ storage = CatalogStorageFormat.empty.copy(
+ properties = Map("path" -> tempPath.getCanonicalPath,
"skipHiveMetadata" -> "true")
+ ),
schema = schema,
- partitionColumns = Array.empty[String],
- bucketSpec = None,
- provider = "parquet",
- options = Map("path" -> tempPath.getCanonicalPath,
"skipHiveMetadata" -> "true"),
- isExternal = false)
+ provider = Some("parquet")
+ )
+ spark.sessionState.catalog.createTable(tableDesc2, ignoreIfExists =
false)
// As a proxy for verifying that the table was stored in SparkSQL
format,
// we verify that the table has a column type as array of StringType.
- assert(sharedState.externalCatalog.getTable("default",
"skip_hive_metadata")
- .schema.forall(_.dataType == ArrayType(StringType)))
+ assert(hiveClient.getTable("default", "skip_hive_metadata").schema
+ .forall(_.dataType == ArrayType(StringType)))
--- End diff --
we need a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
