Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r75432607
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -584,13 +579,8 @@ case class AlterTableSetLocationCommand(
object DDLUtils {
-
- def isDatasourceTable(props: Map[String, String]): Boolean = {
- props.contains(DATASOURCE_PROVIDER)
- }
-
def isDatasourceTable(table: CatalogTable): Boolean = {
- isDatasourceTable(table.properties)
+ table.provider.isDefined && table.provider.get != "hive"
--- End diff --
We are checking the same thing but using different ways. See the code:
https://github.com/cloud-fan/spark/blob/96d57b665ac65750eb5c6f9757e5827ea9c14ca4/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L175
Could we make them consistent? or leave a comment to explain it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
