Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76338652
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,14 @@ case class HashAggregateExec(
.map(_.asInstanceOf[DeclarativeAggregate])
private val bufferSchema =
StructType.fromAttributes(aggregateBufferAttributes)
- // The name for Vectorized HashMap
- private var vectorizedHashMapTerm: String = _
- private var isVectorizedHashMapEnabled: Boolean = _
+ // The name for Fast HashMap
+ private var fastHashMapTerm: String = _
+ private var isFastHashMapEnabled: Boolean = false
+
+ // whether a vectorized hashmap is used instead
+ // we have decided to always use the row-based hashmap,
+ // but the vectorized hashmap can still be switched on for testing and
benchmarking purposes.
+ private var isVectorizedHashMapEnabled: Boolean = false
--- End diff --
If it is only used in testing/benchmarking, is it worthy to put this piece
in the production code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
