Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76338880
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -459,52 +475,91 @@ case class HashAggregateExec(
}
/**
- * Using the vectorized hash map in HashAggregate is currently supported
for all primitive
- * data types during partial aggregation. However, we currently only
enable the hash map for a
- * subset of cases that've been verified to show performance
improvements on our benchmarks
- * subject to an internal conf that sets an upper limit on the maximum
length of the aggregate
- * key/value schema.
- *
+ * A required check for any fast hash map implementation (basically the
common requirements
+ * for row-based and vectorized).
+ * Currently fast hash map is supported for primitive data types during
partial aggregation.
* This list of supported use-cases should be expanded over time.
*/
- private def enableVectorizedHashMap(ctx: CodegenContext): Boolean = {
- val schemaLength = (groupingKeySchema ++ bufferSchema).length
+ private def checkIfFastHashMapSupported(ctx: CodegenContext): Boolean = {
val isSupported =
(groupingKeySchema ++ bufferSchema).forall(f =>
ctx.isPrimitiveType(f.dataType) ||
f.dataType.isInstanceOf[DecimalType] ||
f.dataType.isInstanceOf[StringType]) &&
bufferSchema.nonEmpty && modes.forall(mode => mode == Partial ||
mode == PartialMerge)
- // We do not support byte array based decimal type for aggregate
values as
- // ColumnVector.putDecimal for high-precision decimals doesn't
currently support in-place
+ // For vectorized hash map, We do not support byte array based decimal
type for aggregate values
--- End diff --
I am not sure whether it still make sense to mention "vectorized hash map,"
here, if the vectorized hash map is not used in the code implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
