GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/14826
[SPARK-16382] [MLLIB] Standard Python-Java MLlib API to accept optional
long seeds in all cases
## What changes were proposed in this pull request?
Related to https://github.com/apache/spark/pull/14524 -- just the 'fix'
rather than a behavior change.
- PythonMLlibAPI methods that take a seed now always take a
`java.lang.Long` consistently, allowing the Python API to specify "no seed"
- .mllib's Word2VecModel seemed to be an odd man out in .mllib in that it
picked its own random seed. Instead it defaults to None, meaning, letting the
Scala implementation pick a seed
- BisectingKMeansModel arguably should not hard-code a seed for consistency
with .mllib, I think. However I left it.
## How was this patch tested?
Existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-16832.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14826.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14826
----
commit 8ac4a9b2fd079c6cb798052b06bfb22d61205729
Author: Sean Owen <so...@cloudera.com>
Date: 2016-08-26T10:48:26Z
Standard Python-Java MLlib API to accept optional long seeds in all cases.
Standardize .mllib classes to deafult to seed=None (except bisecting KMeans)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
