Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/14826#discussion_r76466875
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -763,11 +764,13 @@ private[python] class PythonMLLibAPI extends
Serializable {
maxBins = maxBins,
categoricalFeaturesInfo = categoricalFeaturesInfo.asScala.toMap)
val cached = data.rdd.persist(StorageLevel.MEMORY_AND_DISK)
+ // Only done because methods below want an int, not an optional Long
+ val intSeed = getSeedOrDefault(seed).toInt
--- End diff --
yeah, I was trying to say that converting to a smaller number of bits would
cause some be more likely than others, but I agree in practice it's not going
to make any difference here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
