Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14835#discussion_r76490832
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -171,7 +175,7 @@ class HistoryServer(
        * @return List of all known applications.
        */
       def getApplicationList(): Iterable[ApplicationHistoryInfo] = {
    -    provider.getListing()
    +    provider.getListing().take(maxApplications)
    --- End diff --
    
    I think you cannot add ".take(maxApplications)" here since it may affect 
other places to get the list of all application history. The only problem is in 
rest endpoint "api/v1/applications".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to