Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/14835
@steveloughran Some follow up and clarifications:
For you comments about people calling the REST API, you are correct that my
change limits the applications available through the api on the history server.
This was my intended behavior, but if you think it'd be better I can switch to
my fallback implementation outlined below.
Alternate implementation that only limits history server and not the api:
I pass the conf value to the js file via a global js var with a getter and
setter (I've done this previously with `threadDumpEnabled` in
`ExecutorsPage.scala` going to `executors.js`)
1. I will add this
2. I added the one test already, for the test you referenced I'm a bit
confused at what you're recommending. Why would `?limit=1` return 0? Or are you
saying to call it after the last line where it deletes the log, if so how would
that test the limit param?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
