Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14842
@xwu0226 I glanced over it and this looks like the right approach.
One a high level I would break this up in two separate PRs: one to add
`NULLS FIRST`/`NULLS LAST` sorting to the unsafe sorter (create a separate JIRA
ticket for this), and the second one to integrate this in Spark SQL (I would
repurpose this one for that). This makes the PRs more targeted and easier to
review.
I do have one question/comment regarding this PR. Why do we need to add
three kinds of null ordering: unknown ordering, nulls first and nulls last?
Can't we merge the unknown ordering with the default behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
