Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
@hvanhovell Thank you so much for reviewing and providing the suggestions.
I will separate this into 2 PRs.
For the question of why we need 3 types of NULL ordering, I was thinking
that the default behavior of NULL Ordering is following the column ordering
ASC|DESC, where NULL is considered always smaller than the NON-null values. So
nulls will be returned first for ASC case, and last for DESC case. In order not
to break any existing test cases and behavior, I chose to have a nullOrder
undefined case, where it goes to the existing behavior. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
